ci: add retry for artifact download steps#1984
Merged
tyrielv merged 1 commit intoMay 26, 2026
Merged
Conversation
Transient failures in actions/download-artifact are a frequent source of flaky CI runs. Add a retry step after each download that triggers only when the first attempt fails (continue-on-error + outcome check). Applied to both functional-tests.yaml and upgrade-tests.yaml. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
derrickstolee
approved these changes
May 26, 2026
Contributor
derrickstolee
left a comment
derrickstolee
left a comment
There was a problem hiding this comment.
It would be nice if the task itself could have retries, but this "maybe just run it again" will help.
Contributor
Author
Agreed - that feature isn't built in to github actions though, it would require referencing a third party action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transient failures in
actions/download-artifactare a frequent source of flaky CI runs — I see these several times a week, always succeeding on manual re-run.This adds a single automatic retry for each
download-artifactstep using thecontinue-on-error+outcome == 'failure'pattern:How it works: Each download step gets
id+continue-on-error: true. A duplicate step follows that only runs when the first attempt failed (steps.<id>.outcome == 'failure'). No new dependencies, no third-party actions.Example of a recent failure this would fix: https://github.com/microsoft/VFSForGit/actions/runs/26310137269/job/77463758324?pr=1981